feat: do not write "Same as previous version" as first thing in a brand-new changelog #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krlmlr
approved these changes
Mar 23, 2023
| @@ -27,14 +27,16 @@ update_news_impl <- function(commits, which) { | |||
| which <- "dev" | |||
| } | |||
| } | |||
| no_news.md_yet <- is.null(fledgeling[["news"]]) | |||
There was a problem hiding this comment.
🙀
Suggested change
| no_news.md_yet <- is.null(fledgeling[["news"]]) | |
| initializing <- is.null(fledgeling[["news"]]) |
Other candidates: just_hatching or brand_new, but this would be confusing too.
| @@ -35,11 +35,11 @@ collect_news <- function(commits) { | |||
|
|
|||
| if (is.null(newsworthy_items)) { | |||
| if (nrow(commits) <= 1) { | |||
| newsworthy_items <- parse_bullet_commit("- Same as previous version.") | |||
| if (fledge_chatty()) cli_alert_info("Same as previous version.") | |||
| newsworthy_items <- parse_bullet_commit(sprintf("- %s", same_as_previous())) | |||
There was a problem hiding this comment.
Did we already switch to glue entirey?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #259