fix: use pkg version from open PR, not from CRAN page #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
krlmlr
reviewed
Apr 3, 2023
Comment on lines
458
to
462
| title = sprintf( | ||
| "CRAN release v%s", | ||
| "%s%s", | ||
| cran_release_pr_title(), | ||
| strsplit(gert::git_branch(), "cran-")[[1]][2] | ||
| ), |
|
Thanks! Going for the branch name would be a bit safer, but this is good enough for now. |
This was referenced Apr 3, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #661
In hindsight, that was not good logic.
Now when that function runs, it acts if there's an open "CRAN release" PR, and uses the version from that PR title.