Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better error message when duplicate version name #673

Merged
merged 2 commits into from
May 27, 2023
Merged

fix: better error message when duplicate version name #673

merged 2 commits into from
May 27, 2023

Conversation

maelle
Copy link
Member

@maelle maelle commented May 23, 2023

Fix #672

> withr::with_dir("../tic", read_fledgling())
Error in `read_news()` at fledge/R/fledgling.R:195:2:
! Can't deal with duplicate version names: tic 0.2.13.9011.
ℹ Fix the duplication then retry.
Backtrace:
 1. withr::with_dir("../tic", read_fledgling())
 3. fledge:::read_fledgling()
 4. fledge:::read_news()
      at fledge/R/fledgling.R:195:2

@pat-s

@maelle maelle marked this pull request as ready for review May 23, 2023 11:54
@maelle maelle requested review from krlmlr and pat-s May 23, 2023 11:54
pat-s
pat-s reviewed May 23, 2023
View reviewed changes
Copy link
Member

@pat-s pat-s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, lgtm!

@krlmlr krlmlr merged commit 3ff7531 into main May 27, 2023
12 checks passed
@krlmlr krlmlr deleted the multiple-versions branch May 27, 2023 08:35
@krlmlr
Copy link
Contributor

krlmlr commented May 27, 2023

Thanks!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pat-s pat-s pat-s left review comments

@krlmlr krlmlr Awaiting requested review from krlmlr

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when using bump_version()
3 participants
@maelle @krlmlr @pat-s