tests: clean up, simplify tests #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maelle
commented
Oct 2, 2023
| @@ -206,7 +206,7 @@ update_cran_comments <- function() { | |||
| } | |||
|
|
|||
| get_crp_date <- function() { | |||
| cmt <- gh::gh("/repos/eddelbuettel/crp/commits")[[1]] | |||
| cmt <- gh("/repos/eddelbuettel/crp/commits")[[1]] | |||
There was a problem hiding this comment.
this change is for being able to mock it while respecting the guidance in https://testthat.r-lib.org/reference/local_mocked_bindings.html#namespaced-calls
maelle
commented
Oct 2, 2023
| @@ -360,10 +360,10 @@ has_internet <- function() { | |||
| if (!rlang::is_installed("curl")) { | |||
| return(FALSE) | |||
| } | |||
| if (nzchar(Sys.getenv("YES_INTERNET_TEST_FLEDGE"))) { | |||
| if (nzchar(Sys.getenv("FLEDGE_YES_INTERNET_TEST"))) { | |||
There was a problem hiding this comment.
these were the only test switches not starting with FLEDGE_ 😬
maelle
commented
Oct 2, 2023
| @@ -1,92 +1,94 @@ | |||
| test_that("bump_version() works -- dev", { | |||
There was a problem hiding this comment.
the diff here: removing the skips as I don't think we need them anymore, same for the variant, and restructuring the test files into paragraphs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #695
Part of #714
expect_snapshot_error(;FLEDGE_;