Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Accept A Student's Received Connection Request #116

Closed
Tracked by #15
arafaysaleem opened this issue Sep 30, 2021 · 0 comments · Fixed by #118 or #120
Closed
Tracked by #15

[PATCH] Accept A Student's Received Connection Request #116

arafaysaleem opened this issue Sep 30, 2021 · 0 comments · Fixed by #118 or #120
Labels
Status: Completed Type: Enhancement Type: Feature user story A brief explanation of a functionality or an interaction with the system, from a user's perspective

Comments

@arafaysaleem
Copy link
Collaborator

arafaysaleem commented Sep 30, 2021

Summary

As a student, I should be able to accept connection requests, so that I can add the student to my friends list.

Acceptance Criteria

GIVEN an student is accepting a friend request in the app
WHEN the app hits the /student-connections/:id endpoint with a valid PATCH request, containing the path parameter:

  • id, the unique id of the entity being edited

AND the following body parameters:

  • connection_status === 'friends'
  • accepted_at datetime

THEN the app should receive a status 200
AND in the response, the following information should be returned:

  • header message indicating update operation success
  • rows matched
  • rows changed

Sample Request/Sample Response

headers: {
    error: 0,
    message: "The specified item was updated successfully"
}
body: {
    rows_matched: 1,
    rows_changed: 1,
    info: "..."
}

Resources

  • Development URL: {Here goes a URL to the feature on development API}
  • Production URL: {Here goes a URL to the feature on production API}

Dev Notes

{Some complementary notes if necessary}

Testing Notes

Scenario 1: PATCH request is successful (Receiver)

  1. Update a friend request with a PATCH request to /student-connections/:id endpoint with receiver_erp == erp in student account token.
  2. A subsequent GET request to /student-connections/:id endpoint should return a status code 200
  3. And the friend request details with the updated information i.e. matching the initially sent body.
  4. Resubmit a PATCH request to /student-connections/:id endpoint to reverse the change and ensure status code 200 is returned.

Scenario 2: PATCH request is incorrect

  1. Send a PATCH request to /student-connections/:id endpoint with an incorrect key name in the body
  2. Ensure a 422 status code is returned
  3. And the response headers' code parameter should contain "InvalidPropertiesException"
  4. And the response headers' data parameter should contain the name of the invalid parameter

Scenario 3: PATCH request is forbidden

  1. Send a PATCH request to /student-connections/:id endpoint with receiver_erp != erp in student account token.
  2. Ensure the response returns a 403 forbidden status code.
  3. And the response headers' code parameter should contain "ForbiddenException"

Scenario 4: PATCH request is unauthorized

  1. Send a PATCH request to /student-connections/:id endpoint without an authorization token
  2. Ensure a 401 unauthorized status code is returned.
  3. And the response headers' code parameter should contain "TokenMissingException"
@arafaysaleem arafaysaleem added Priority: Medium Status: Pending Type: Feature user story A brief explanation of a functionality or an interaction with the system, from a user's perspective labels Sep 30, 2021
@arafaysaleem arafaysaleem mentioned this issue Oct 6, 2021
13 tasks
@arafaysaleem arafaysaleem mentioned this issue Oct 8, 2021
10 tasks
@arafaysaleem arafaysaleem changed the title [PATCH] A Student's Received Friend Request [PATCH] A Student's Received Connection Request Oct 10, 2021
@arafaysaleem arafaysaleem reopened this Oct 10, 2021
@arafaysaleem arafaysaleem changed the title [PATCH] A Student's Received Connection Request [PATCH] Accept A Student's Received Connection Request Oct 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Completed Type: Enhancement Type: Feature user story A brief explanation of a functionality or an interaction with the system, from a user's perspective
Projects
None yet
1 participant