Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

404 on api token link if company missing #11

Open
mountainash opened this issue Apr 16, 2020 · 0 comments
Open

404 on api token link if company missing #11

mountainash opened this issue Apr 16, 2020 · 0 comments

Comments

@mountainash
Copy link

Ref:

hakuna-menubar/preferences.html

Line 67 in bb03388

shell.openExternal(`https://${document.getElementById('company-name').value}.hakuna.ch/token`)

If the "API" link is click before the user has entered the Hakuna sub-domain, the link goes to a 404 on the Hakuna website.

Possible changes are:

  1. Change the flow of the instructions until after the subdomain field
  2. don't show/action the link until the company-name contains a value
  3. Ask Hakuna not to show a 404 🤷‍♂️
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mountainash