Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A2C loss calculations #2

Closed
koryakinp opened this issue Nov 18, 2019 · 1 comment
Closed

A2C loss calculations #2

koryakinp opened this issue Nov 18, 2019 · 1 comment

Comments

@koryakinp
Copy link

koryakinp commented Nov 18, 2019 •
edited

https://github.com/cyoon1729/Reinforcement-learning/blob/d157d0d86c37734be4b430b7d311eb9bb0379d93/Policy-Gradient-Methods/a2c/a2c.py#L42

Sir, can you please explain why value_targets = rewards + discounted_rewards ?
Why do you need to add rewards and discounted rewards together ?
@cyoon1729
Copy link
Owner

That was a mistake on my part, sorry for the late reply. I have fixed those changes in the recent refactoring!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koryakinp @cyoon1729