Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider migrating to io/fs.StatFS for SecureJoinVFS #11

Open
cyphar opened this issue May 4, 2024 · 1 comment
Open

consider migrating to io/fs.StatFS for SecureJoinVFS #11

cyphar opened this issue May 4, 2024 · 1 comment

Comments

@cyphar
Copy link
Owner

cyphar commented May 4, 2024

Now the Go has their own "generic" interfaces for filesystem roots, maybe it would make sense to migrate to using that rather than our own home-brew thing. Note that we want to be given the equivalent of fs.DirFS("/") not fs.DirFS(root) -- we are implementing our own resolution logic, and the unsafe path.Join logic in io/fs is not going to work.

@cyphar
Copy link
Owner Author

cyphar commented May 5, 2024

It seems that there's no way to Readlink with io/fs.FS, and it also seems that they expect implementations to follow trailing symlinks (though the docs seem a little unclear). So this might not be possible...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant