Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SYSTEM_ALERT_WINDOW permission #796

Open
1 task done
jermanuts opened this issue Mar 7, 2024 · 2 comments
Open
1 task done

Remove SYSTEM_ALERT_WINDOW permission #796

jermanuts opened this issue Mar 7, 2024 · 2 comments

Comments

@jermanuts
Copy link

jermanuts commented Mar 7, 2024

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

This permission makes it possible to draw over other apps which is security risk and I don't think Stack Wallet makes use of that permission anyways, so having it is pointless. If you want some kind of protection and prevent apps from drawing over Stack Wallet, you could use HIDE_OVERLAY_WINDOWS which will increase Stack Wallet security.

Expected Behavior

Stop using this permission and use the other recommended permission for enhanced security.

Reproduce Steps

.

Environment

.

Logs

No response

Further Information

https://code.briarproject.org/briar/briar/-/issues/956#note_20639

https://blog.nviso.eu/2021/05/11/new-malware-family-now-also-targets-belgian-financial-apps/

@jermanuts jermanuts changed the title Bug: Remove SYSTEM_ALERT_WINDOW permission Remove SYSTEM_ALERT_WINDOW permission Mar 10, 2024
@julian-CStack
Copy link
Collaborator

We don't use that permission https://github.com/cypherstack/stack_wallet/blob/main/android/app/src/main/AndroidManifest.xml
Its possible some library uses it. Could you point to where you've found it being used?

@jermanuts
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants