Skip to content
This repository has been archived by the owner on Jan 31, 2023. It is now read-only.

babelify should not be removed when .typescript is set #61

Open
ben8p opened this issue Jan 8, 2021 · 0 comments
Open

babelify should not be removed when .typescript is set #61

ben8p opened this issue Jan 8, 2021 · 0 comments
Assignees

Comments

@ben8p
Copy link

ben8p commented Jan 8, 2021

  • Operating System: Ubuntu 18.04
  • Cypress Version: 6.1.0
  • Browser Version: Chrome 87.0.4280.88

Is this a Feature or Bug?

This is a bug

Current behavior:

When .typescript option is set, babelify is removed from the transforms.
As a result, if the typescript file is dependent on a JS module using ES6, the transpilation will fail.

Desired behavior:

babelify should not be removed when using typescript as it may still be useful, as described here: #19

the line browserifyOptions.transform = transform.filter((stage) => !Array.isArray(stage) || !stage[0].includes('babelify')) should be changed accordingly

How to reproduce:

  • write a typscript file with a depdency to a JS es6 module
  • run the code

it crash

Additional Info (images, stack traces, etc)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants