Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependencies in @cypress/react #14165

Merged
merged 4 commits into from
Dec 16, 2020

Conversation

anark
Copy link
Contributor

@anark anark commented Dec 14, 2020

  • Closes

User facing changelog

Updates dependencies used by @cypress/react to match latest version from cypress-react-unit-test instead of a regression

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 14, 2020

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Dec 14, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anark Thanks for the contribution! Could you please sign our CLA?

@jennifer-shehane jennifer-shehane changed the title update dependencies in @cypress/react fix(deps): update dependencies in @cypress/react Dec 14, 2020
@jennifer-shehane jennifer-shehane dismissed their stale review December 15, 2020 04:31

Dismissing my review for code review

@jennifer-shehane jennifer-shehane requested review from a team and removed request for jennifer-shehane December 15, 2020 04:32
lmiller1990
lmiller1990 previously approved these changes Dec 15, 2020
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green so a big ✅ for me

@dmtrKovalenko
Copy link
Contributor

Did you run yarn install? wondering why lockfile did not updated – and as a result tests were not run on CI with new deps

Copy link
Contributor

@dmtrKovalenko dmtrKovalenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update a lock file and pass CI with the new deps

@dmtrKovalenko dmtrKovalenko merged commit 2c4349e into cypress-io:develop Dec 16, 2020
@anark
Copy link
Contributor Author

anark commented Dec 16, 2020

Thank you!

Would it be possible to get a version bump on @cypress/react

@dmtrKovalenko
Copy link
Contributor

Will be auto released on monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants