Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Component Testing): Broken links in docs #14251

Conversation

alfonsoar
Copy link
Contributor

@alfonsoar alfonsoar commented Dec 19, 2020

This PR fixes a few broken links in the component testing docs.

  • Closes N/A

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 19, 2020

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Dec 19, 2020

CLA assistant check
All committers have signed the CLA.

@alfonsoar
Copy link
Contributor Author

@JessicaSachs @dmtrKovalenko @bahmutov perhaps one of you can review this?

@alfonsoar alfonsoar changed the title fix(Component Testing): Broken link in docs fix(Component Testing): Broken links in docs Dec 19, 2020
@@ -437,7 +436,7 @@ DEBUG=@cypress/react,find-webpack

### From v3 to v4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this can be entirely deleted

@dmtrKovalenko
Copy link
Contributor

This looks great, thank you for this fix :)

@dmtrKovalenko dmtrKovalenko merged commit a72529f into cypress-io:develop Dec 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants