Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct typo in @types/react peerDependencyMeta entry #14306

Merged
merged 2 commits into from
Dec 24, 2020

Conversation

phoenixeliot
Copy link
Contributor

@phoenixeliot phoenixeliot commented Dec 24, 2020

User facing changelog

Fixes an incorrect peerDependencyMeta in @cypress/react, which prevented it from being installed with Yarn 2.

Additional details

I have not tried to verify the correctness of the package.json code surrounding this; I only know that this fixes the error upon installation.

How has the user experience changed?

This makes the package installable with Yarn 2.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 24, 2020

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Dec 24, 2020

CLA assistant check
All committers have signed the CLA.

@phoenixeliot phoenixeliot marked this pull request as ready for review December 24, 2020 06:32
@JessicaSachs JessicaSachs changed the base branch from develop to master December 24, 2020 07:34
@JessicaSachs JessicaSachs changed the base branch from master to develop December 24, 2020 07:35
@JessicaSachs
Copy link
Contributor

This LGTM! Just needed to fix the package.json linter and then I'll merge it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yarn 2 chokes on @cypress/react's peerDependenciesMeta key "types/react"
3 participants