Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Studio prompts user to enter url even if an error has already occured #14686

Closed
panzarino opened this issue Jan 22, 2021 · 2 comments · Fixed by #14696
Closed

Studio prompts user to enter url even if an error has already occured #14686

panzarino opened this issue Jan 22, 2021 · 2 comments · Fixed by #14696
Assignees
Labels
experiment: studio Issues when using experimentalStudio type: bug

Comments

@panzarino
Copy link
Contributor

Current behavior

If a test has failed and the user has not yet visit a url, they will still be prompted to enter a url.

Note: does not happen for failed cy.visit(...) commands as that was the only situation in which I ran into this during initial development and fixed.

Desired behavior

Studio should not prompt the user to enter a url if their test has already failed

Test code to reproduce

Attempting to extend the following suite produces this error:

describe('studio', () => {
  beforeEach(() => {
    throw new Error('My Error')
  })

  it('types', () => {

  })
})

Screen Shot 2021-01-21 at 10 51 58 PM

@panzarino panzarino added type: bug experiment: studio Issues when using experimentalStudio labels Jan 22, 2021
@panzarino panzarino self-assigned this Jan 22, 2021
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jan 22, 2021
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress stage: needs review The PR code is done & tested, needs review labels Jan 22, 2021
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jan 27, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 27, 2021

The code for this is done in cypress-io/cypress#14696, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 1, 2021

Released in 6.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
experiment: studio Issues when using experimentalStudio type: bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant