Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel button should appear under error for failed tests in Studio #14691

Closed
panzarino opened this issue Jan 22, 2021 · 2 comments · Fixed by #14696
Closed

Cancel button should appear under error for failed tests in Studio #14691

panzarino opened this issue Jan 22, 2021 · 2 comments · Fixed by #14696
Assignees
Labels
experiment: studio Issues when using experimentalStudio type: enhancement Requested enhancement of existing feature

Comments

@panzarino
Copy link
Contributor

What would you like?

The cancel button (that usually appears in the same line as the "Save Commands" button) should appear when a test has finished running in Studio mode even if the test does not pass.

When a test has passed and is actively being edited:

Screen Shot 2021-01-21 at 11 22 00 PM

Why is this needed?

The controls on the right side are less noticeable and may be missed in this situation. When a test passes, this button is available in the bottom left so it only makes sense that it would if the test fails since the user is most likely looking for the quickest way to exit.

This is what that state currently looks like, with the only exit being the 'X' in the top right:

Screen Shot 2021-01-21 at 11 18 16 PM

@panzarino panzarino added type: enhancement Requested enhancement of existing feature experiment: studio Issues when using experimentalStudio labels Jan 22, 2021
@panzarino panzarino self-assigned this Jan 22, 2021
@cypress-bot cypress-bot bot added the stage: ready for work The issue is reproducible and in scope label Jan 22, 2021
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress stage: needs review The PR code is done & tested, needs review labels Jan 22, 2021
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jan 27, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jan 27, 2021

The code for this is done in cypress-io/cypress#14696, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 1, 2021

Released in 6.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
experiment: studio Issues when using experimentalStudio type: enhancement Requested enhancement of existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant