Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove truncation of preprocessor errors #15198

Merged

Conversation

chrisbreiding
Copy link
Contributor

@chrisbreiding chrisbreiding commented Feb 23, 2021

User facing changelog

  • Cypress now displays the stack from errors thrown in the preprocessor.

Additional details

We used to remove the stack from where there was a preprocessor error. I don't remember why. It may have been that we thought the error was overly verbose when we displayed it. But removing the stack makes it very difficult to debug a preprocessor, so it's better if we keep it and err on the side of it being verbose.

How has the user experience changed?

Users now see the error stack when there's a preprocessor error.

Before

Screen Shot 2021-02-23 at 3 43 19 PM

After

Screen Shot 2021-02-23 at 3 45 13 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 23, 2021

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding changed the title remove truncation of preprocessor errors chore: Remove truncation of preprocessor errors Feb 23, 2021
@cypress
Copy link

cypress bot commented Feb 23, 2021



Test summary

9337 0 118 3


Run details

Project cypress
Status Passed
Commit 800c809
Started Feb 24, 2021 7:21 PM
Ended Feb 24, 2021 7:32 PM
Duration 10:47 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this should be helpful. It probably was originally for readability because people see a wall of text in an error message sometimes and go 😵

flotwig
flotwig previously approved these changes Feb 24, 2021
@flotwig
Copy link
Contributor

flotwig commented Feb 24, 2021

Yeah, this should be helpful. It probably was originally for readability because people see a wall of text in an error message sometimes and go dizzy_face

yeah, you'd think people would be eager to read errors since it usually leads you to a solution, but strangely this is not a universal trait

@chrisbreiding chrisbreiding changed the title chore: Remove truncation of preprocessor errors fix: Remove truncation of preprocessor errors Feb 24, 2021
@chrisbreiding chrisbreiding merged commit f81dfec into develop Feb 24, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 15, 2021

Released in 6.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 15, 2021
@chrisbreiding chrisbreiding deleted the TR-667-remove-preprocessor-error-stack-truncation branch April 5, 2022 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants