-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Remove truncation of preprocessor errors #15198
fix: Remove truncation of preprocessor errors #15198
Conversation
Thanks for taking the time to open a PR!
|
Test summaryRun details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, this should be helpful. It probably was originally for readability because people see a wall of text in an error message sometimes and go 😵
yeah, you'd think people would be eager to read errors since it usually leads you to a solution, but strangely this is not a universal trait |
6638fb4
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
User facing changelog
Additional details
We used to remove the stack from where there was a preprocessor error. I don't remember why. It may have been that we thought the error was overly verbose when we displayed it. But removing the stack makes it very difficult to debug a preprocessor, so it's better if we keep it and err on the side of it being verbose.
How has the user experience changed?
Users now see the error stack when there's a preprocessor error.
Before
After
PR Tasks
cypress-documentation
?type definitions
?cypress.schema.json
?