Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reloading Cypress after unexpected error results in crash #15360

Closed
JonahKK opened this issue Mar 8, 2021 · 3 comments
Closed

Reloading Cypress after unexpected error results in crash #15360

JonahKK opened this issue Mar 8, 2021 · 3 comments
Labels
type: regression A bug that didn't appear until a specific Cy version release v6.5.0 🐛 Issue present since 6.5.0

Comments

@JonahKK
Copy link

JonahKK commented Mar 8, 2021

Current behavior

When Cypress Runner (launched with cypress open) encounters an error it allows for reloading (Try Again option).
image
When the Try Again button is clicked then the Cypress crashes and following errors are displayed:
image

Desired behavior

Reload should not end with crash.

Test code to reproduce

The easiest way to reproduce is:

  1. Open Cypress with cypress open.
  2. Change cypress.json that is no longer valid.
  3. Unexpected error screen should be displayed.

Versions

6.5.0

@jennifer-shehane jennifer-shehane added v6.5.0 🐛 Issue present since 6.5.0 type: regression A bug that didn't appear until a specific Cy version release stage: ready for work The issue is reproducible and in scope labels Mar 16, 2021
@jennifer-shehane
Copy link
Member

Yeah, this is easily reproducible. This was introduced in 6.5.0.

Screen Shot 2021-03-16 at 6 54 24 PM

cypress.json

{,}
  1. Run cypress open
  2. Tap 'Try again' in GUI.

Looks like this error is constructed and thrown by us ourselves. https://github.com/cypress-io/cypress/blob/develop/packages/server/lib/util/class-helpers.ts#L14:L14

This error was introduced in #14479

@JessicaSachs JessicaSachs self-assigned this Mar 17, 2021
@jennifer-shehane
Copy link
Member

In 8.2.0, this no longer crashes but causes the UI to spin forever.

Screen Shot 2021-08-09 at 8 17 47 AM

@jennifer-shehane
Copy link
Member

This is no longer an issue. Tried in Cypress 8.6.0.

@jennifer-shehane jennifer-shehane removed the stage: ready for work The issue is reproducible and in scope label Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: regression A bug that didn't appear until a specific Cy version release v6.5.0 🐛 Issue present since 6.5.0
Projects
None yet
Development

No branches or pull requests

3 participants