fix: Revert cypress.json changes #15499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
This was referenced Mar 15, 2021
chrisbreiding
commented
Mar 15, 2021
Comment on lines
+212
to
+213
| config: _.cloneDeep(settings), | ||
| envFile: _.cloneDeep(envFile), |
There was a problem hiding this comment.
The only code changes besides the reverting.
chrisbreiding
commented
Mar 15, 2021
Comment on lines
+83
to
+95
| it('clones settings and env settings, so they are not mutated', function () { | ||
| const settings = { foo: 'bar' } | ||
| const envSettings = { baz: 'qux' } | ||
|
|
||
| this.setup(settings, envSettings) | ||
|
|
||
| return config.get(this.projectRoot) | ||
| .then(() => { | ||
| expect(settings).to.deep.equal({ foo: 'bar' }) | ||
| expect(envSettings).to.deep.equal({ baz: 'qux' }) | ||
| }) | ||
| }) | ||
|
|
There was a problem hiding this comment.
New test to make sure cypress settings don't get mutated.
|
nice. @chrisbreiding do you think we should squash+rebase this into three commits (two reverts, one bugfix) and do a merge commit? it would be nice to have the explicit revert commits in develop |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
chrisbreiding
force-pushed
the
revert-cypress-json-changes
branch
from
43eb3d5
to
4886f23
Compare
kuceb
previously approved these changes
Mar 15, 2021
chrisbreiding
force-pushed
the
revert-cypress-json-changes
branch
from
4886f23
to
496e458
Compare
This was referenced Mar 16, 2021
This was referenced Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
cypress.jsonwhen adding the project IDAdditional details
This was caused by a combination of using
requireto obtain the contents ofcypress.jsonand mutating the config object itself. Since node caches required modules, it mutated the in-memory cache of thecypress.json, so subsequent 'reads' had the mutated content with extra values, which then got written back to the file when writing the project ID.This reverts PRs #15444 and #15263.
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?