-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto scroll is turned off sometimes #16098
Comments
That's pretty weird. I don't see where this code would have been updated at all recently, so I don't think this would be a regression. Also it seems like in the code that this should only toggle if you click on it? Providing a way to reproduce this reliably would be helpful, without that this will be pretty difficult to track down. |
It's in CI so no one clicked on it |
I've noticed this as well during recordings from our test runs in CI. It's making it difficult (if not impossible) to really tell what's going on the video because the command log doesn't scroll and so we can't see what command is being executed at the time of failure. EDIT: I guess I should also say that we are using Cypress 7.2.0. |
I have seen the same behavior on our CI also and we use cypress 8.7.0 on Gitlab. It's not happening to all tests runs but this is an example and I cannot reproduce it locally : cypress-scrolling-on-ci.movThis is the reason that we add this plugin to see what's going on when a test fails: https://github.com/bahmutov/cypress-failed-log Can we ensure somehow this scrollbar tries always to go to the bottom? Is there any test for that? |
After upgrading to cypress 9.4.1 we still see this behavior on Gitlab Pipelines |
We do indeed have extensive tests around the scrolling behavior, and as noted, this isn't something we've seen in cypress' own tests. Which isn't to say that your issue isn't real, just that without a publicly visible case demonstrating it, we're pretty limited in our ability to figure out what's going on. If you can reproduce the behavior in a public repo, I'm definitely willing to spend some time looking into it. |
I'm seeing this happen regularly in our CI tests, which makes the screenshots and videos useless. We're on Cypress 9.5 in Gitlab, though I see the behavior in Jenkins as well. We use 'npx cypress run' with Electron. |
I'm watching the behavior of the scroll across our different tests, and one thing that I notice is that it seems to freeze when there are several requests being made at once, especially if they are resolving at different times, and particularly if there are enough requests that either the lagging request (above) or the new one (below) scrolls out of view for a moment. I'm looking at the video that jpourdanis posted and the same behavior seems to occur in his video - the scroll stops immediately after several requests at once suddenly push the remaining tests out of view. I can confirm it is not related to test order or number of tests in a file (so whether there are tests shown below the logs does not matter, I've seen it happen on the first and last tests and when there is only one test in the spec file). |
Also seeing it with same context.
|
I agree with @dlabrecque-uzinakod. How useful is this feature? Perhaps the fix to this issue is to remove the feature completely? |
The reason we have this feature is for users reviewing video artifacts in CI to debug what happened in a failing test. It makes a lot of sense for those workflows. I have a 100% reproduction with this repository https://github.com/JessicaSachs/rune-scrape Video here: https://www.loom.com/share/61ff11e54ae6457c93b8d2191aa31b65 best listened to at 1.5x 🐢 |
@JessicaSachs I understand, but what would be the use case for disabling auto scroll? I suppose my comment's a bit ambiguous. The suggestion was to remove the toggle and keep in always on. |
Thanks @JessicaSachs for the video. |
A starting point for the implementation of this might be, when in headless mode, to not do this scroll handling, since any scrollbar movement was definitely not caused by the user wanting to pause autoscrolling to look at something - they can't see the browser. |
Marking #22772 as a duplicate of this issue. Seems related to auto-scroll stopping mid-spec |
After upgrading to v10 we are now encountering this issue as well. It happens both in the runner and in CI which makes it particularly irritating. Screen.Recording.2022-07-22.at.08.23.48.mov. |
Hi folks, I have a build that removes the "temporarily disable auto scrolling" feature for non-interactive mode. The reason I didn't fully remove that feature, is that in open mode, when tests are running, I think users pretty often will actually scroll the reporter manually while tests run, and it's fair to expect that to work. Removing that would probably cause some frustration, so it might be more suitable as a configuration or something eventually. But there's a big caveat. I could not reproduce this issue at all, no matter what I tried. I let @JessicaSachs's tests run over and over and even though this happened for her in the video she shared, I never once saw the autoscroll fail or turn off on its own. So I have no idea if the code I changed actually addresses this problem. It's a hunch. Preview builds of the Cypress binary for linux and mac can be found in the comments here: #23053 (comment) @steve78GA or @JessicaSachs, maybe one of you who can reproduce can try the altered binary and confirm if, using |
Thanks @DannyBunny, and shoot it looks like I started my branch during the hot second that Will check back on Monday. EDIT: the links don't seem to always include the commit comments, so here is the command for windows:
|
Any news about this, It's happening to me even when I run the test in my local machine. The auto scroll stops working after some time. This is really annoying when it happens on CI because it leaves me with NO LOGS to see what cypress is doing. THis makes IMPOSIBLE to review the failures.... I have cypress version 10.4.0 |
@cposada23 since you can reproduce, can you verify one of these builds fixes the problem (using I've tried a bunch to reproduce it and had several others trying as well but we have not at any luck. Linux: Windows: Mac: Mac (ARM): @Tom5om are you able to confirm if the problem was truly fixed for you? @ngandymovpr would you be able to try one of these builds? |
Yes @marktnoonan I have implemented this build in my pipelines and have not seen the issue since |
I had the same issue for one of my specs with Cypress 10.3.0. There it occurred in about 50% of the times. Since I installed your Build, I have done 15 more runs and have not seen this behavior again. |
@marktnoonan can we get it merged, it's impacting us too. Thank you |
Thanks @leonard2901 and @Tom5om, that seems like plenty validation that this was the issue. @kevingorry this thread should automatically update when the PR is merged, it will need a test as well, which @viniciuspietscher has offered to pick up to get the PR over the finish line. This will likely make it into the next Cypress release at the end of the month. |
@marktnoonan hello, any updates on this? This is really critical issue |
I update to cypress version 10.7.0.... Still happening.... am I really the only one that's getting this annoying behavior ? It's really impossible to see what is happening on the video when I run the test on CI. Guess we just need to change the testing framework |
😄😄 yeah |
Hi folks, this just missed the cut for 10.7.0 due to a conflict with some of the changes made to bring Studio back. PR is updated now, hoping to merge in the next few days. |
The code for this is done in cypress-io/cypress#23053, but has yet to be released. |
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Current behavior
As you can see in the video below, auto scroll turns off at 27s mark and then stays off for the rest of the spec:
Cypress.mp4
It's not consistent, it happened locally more often than in CI, but the recording above is from CI.
Desired behavior
I'd like it to stay on, as there's no way to see the commands without it.
Versions
Cypress
7.1.0
The text was updated successfully, but these errors were encountered: