Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'New Spec File' filename adds extra dots #16131

Closed
GregLahaye opened this issue Apr 22, 2021 · 3 comments · Fixed by #16144
Closed

'New Spec File' filename adds extra dots #16131

GregLahaye opened this issue Apr 22, 2021 · 3 comments · Fixed by #16144

Comments

@GregLahaye
Copy link
Contributor

Current behavior

As you can see in the video below, switching between JavaScript and TypeScript in the dialog will add a new dot to the end of the filename each time.

Desired behavior

No extra dots! My guess would be the extensions here

filters: [{
name: 'JavaScript',
extensions: ['.js'],
}, {
name: 'TypeScript',
extensions: ['.ts'],
}, {
name: 'Other',
extensions: ['*'],
}],
shouldn't have dots (e.g. ['.js'] -> ['js']

Test code to reproduce

2021-04-22_13-01-47.mp4

Versions

7.1.0

@jennifer-shehane
Copy link
Member

This issue doesn't occur for me on Mac, so may be Windows. But also, yes, it should not require the dots for the specified extensions: https://www.electronjs.org/docs/api/dialog#dialogshowopendialogsyncbrowserwindow-options

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 27, 2021

The code for this is done in cypress-io/cypress#16144, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Apr 27, 2021
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 10, 2021

Released in 7.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v7.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants