Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs are hard to read when inactive #1661

Closed
nothingismagick opened this issue May 2, 2018 · 6 comments · Fixed by #5503
Closed

Tabs are hard to read when inactive #1661

nothingismagick opened this issue May 2, 2018 · 6 comments · Fixed by #5503
Labels
good first issue Good for newcomers pkg/extension This is due to an issue in the packages/extension directory type: user experience Improvements needed for UX

Comments

@nothingismagick
Copy link

Current behavior:

screen shot 2018-05-02 at 18 10 35

Desired behavior:

Perhaps a contrasting color / hue instead of Black text on Dark Gray tab.

Steps to reproduce:

Open a second tab.

Versions

v2.1.0 MacOS Chrome

@jennifer-shehane jennifer-shehane added pkg/extension This is due to an issue in the packages/extension directory stage: ready for work The issue is reproducible and in scope type: user experience Improvements needed for UX labels May 2, 2018
@jennifer-shehane
Copy link
Member

This can be fixed from within our extension. It's been a long while since I touched this code, but if anyone is familiar with Chrome themes -> here it is: https://github.com/cypress-io/cypress/blob/develop/packages/extension/theme/manifest.json#L1

@xeger
Copy link

xeger commented Apr 9, 2019

On a related note, the Cypress theme is amusingly almost identical to the default colors of the Mac OS X Dark theme.

These issues aren't enough of an annoyance that I feel like leaping into action to teach myself Chrome plugins - but if I get a bee in my bonnet at some point I'll try to puzzle through both of theme.

@jennifer-shehane jennifer-shehane added the good first issue Good for newcomers label Apr 24, 2019
@jennifer-shehane
Copy link
Member

Well, our theme came out before Mac OSX Dark theme, so sounds like Mac copied us. 😝

@gabbersepp
Copy link
Contributor

Is this still relevant? If I install the theme of the current develop branch on WIn10 Chrome, i dont see black text but a light grey on dark grey:
image

If yes, I can set the color to white. Would look like this:
image

@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Oct 28, 2019
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Oct 31, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 31, 2019

The code for this is done in cypress-io/cypress#5503, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 5, 2019

Released in 3.6.0.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers pkg/extension This is due to an issue in the packages/extension directory type: user experience Improvements needed for UX
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants