Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update @cypress/schematic to NOT remove e2e folder or dependencies. #16692

Merged
merged 5 commits into from
May 26, 2021

Conversation

admah
Copy link
Contributor

@admah admah commented May 26, 2021

User facing changelog

  • update @cypress/schematic to NOT remove e2e folder or dependencies
  • update @cypress/schematic inserted package.json commands to match docs
  • update @cypress/schematic README and LICENSE attributions

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@linear
Copy link

linear bot commented May 26, 2021

DX-310 Update README with following copy at bottom

The Cypress Angular Schematic package was made possible by the original work of the Briebug team and the contributors of @briebug/cypress-schematic.

@briebug/cypress-schematic served as the starting point for improvements and new functionality the Cypress team will continue to develop along with the community.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 26, 2021

Thanks for taking the time to open a PR!

@admah admah requested a review from amirrustam May 26, 2021 15:57
@cypress
Copy link

cypress bot commented May 26, 2021



Test summary

17968 0 214 7Flakiness 0


Run details

Project cypress
Status Passed
Commit a1d5b79
Started May 26, 2021 5:57 PM
Ended May 26, 2021 6:09 PM
Duration 12:13 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

amirrustam
amirrustam previously approved these changes May 26, 2021
Copy link
Contributor

@amirrustam amirrustam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@admah I think we got to think more about the copy for presenting the migration guide link, but this is all valuable to folks in the current state. So we can ship it.

@admah admah merged commit 8b5bad0 into master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants