the times parameter in cy.interceptor is not respected

[A-ZC-Lau]

Current behavior

When the times parameter is used in RouteMatcher, it doesn't respect the limit (i.e. using times: 1 will still match more than once

Desired behavior

It should only match up to the times specified.

Test code to reproduce

/// <reference types="Cypress" />
/* global cy */

before(() => {
	cy.visit("https://mocki.io/fake-json-api");
});

describe(
	"interceptor times test",
	function () {
		it(
			"should not intercept twice",
			function () {
				const routeMatcher = {
					method: "POST",
					times: 1,
					url: /graphql$/
				};
				cy.intercept(
					routeMatcher,
					(req) => {
						req.continue(res => {
							console.log("hello i am here");
							console.log(res);
						});
					}
				)
					.as("interceptor");
				cy.get("#success").should("not.be.visible");
				cy.get("#body").type("{ \"abc\": 123 }", { parseSpecialCharSequences: false });
				cy.get("#create").click();
				cy.get("#success").should("be.visible", { timeout: 10000 });

				cy.get("#body").clear().type("{ \"another\": 123 }", { parseSpecialCharSequences: false });
				cy.get("#create").click();
				cy.get("#success").should("not.be.visible");
				cy.get("#success").should("be.visible", { timeout: 10000 });
			});
	});

Versions

7.4

[jennifer-shehane]

I can verify the issue described above. I modified the example slightly so that there is a failing test (that should be passing).

The test should only mock the data the first time the request matches (because times: 1 was passed), but it passes on 2 requests.

it('should not intercept twice', () => {
  cy.visit('https://mocki.io/fake-json-api')
  
  cy.intercept({
    method: 'POST',
    times: 1,
    url: /graphql$/
  },
    (req) => {
      req.continue(res => {
        res.body.data.createPublicStage.url = 'foobar'
      })
    }
  ).as('interceptor')

  cy.get('#success').should('not.be.visible')
  cy.get('#body').type('{ "abc": 123 }', { parseSpecialCharSequences: false })
  cy.get('#create').click() // submit form that will generate url
  // ✅ success msg contains mocked 'url' dats in 1st match
  cy.get('#success').should('contain', 'foobar') 

  cy.get('#body').clear().type('{ "another": 123 }', { parseSpecialCharSequences: false })
  cy.get('#create').click() // submit form that will generate url
  cy.get('#success').should('not.be.visible') // make sure the succes msg rerenders
  cy.get('#success').should('be.visible')
    // ❗️ success msg shouldn't contain mocked 'url' data in 2nd match
    .and('not.contain', 'foobar') 
})

[sainthkh]

I ran the example above and found out that cy.intercept intercepts once correctly.

The thing we need to check is why foobar is applied twice.

[jennifer-shehane]

@sainthkh I'm seeing the exact opposite behavior, in Cypress 7.6.0.

[sainthkh]

@jennifer-shehane It's because I didn't restart Cypress after modifying code. I fixed the problem and opened the PR.

@A-ZC-Lau After fixing the req.continue behavior`, @jennifer-shehane's test is still failing. I guess it's because of the cache problem on mocki.io's side.

I genereated the api urls with {"abe":123} and {"another":123}, but they were same. Is this intended behavior?

[cypress-bot]

The code for this is done in cypress-io/cypress#17138, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

[cypress-bot]

Released in 8.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.0.0, please open a new issue.