Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure @cypress/schematic is installed as devDependency #16965

Merged
merged 1 commit into from
Jun 17, 2021

Conversation

admah
Copy link
Contributor

@admah admah commented Jun 16, 2021

User Facing Changelog

  • Update package.json to ensure schematic is installed as devDependency

Additional Details

Use the save option of ng-add to configure if the library should be added to the dependencies, the devDepedencies, or not saved at all in the project's package.json configuration file. https://angular.io/guide/schematics-for-libraries#define-dependency-type

  • Not sure if there’s a way y’all have set up already to test this.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 16, 2021

Thanks for taking the time to open a PR!

@admah admah changed the base branch from develop to master June 16, 2021 19:58
@admah admah changed the title fix: ensure schematic is installed as devDependency fix: ensure @cypress/schematic is installed as devDependency Jun 16, 2021
@cypress
Copy link

cypress bot commented Jun 16, 2021



Test summary

8161 0 100 4Flakiness 0


Run details

Project cypress
Status Passed
Commit 7f6de3b
Started Jun 17, 2021 4:48 PM
Ended Jun 17, 2021 4:58 PM
Duration 10:11 💡
OS Linux Debian - 10.8
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@admah admah added the npm: @cypress/schematic @cypress/schematic package issues label Jun 16, 2021
@admah admah merged commit b49fcaf into master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm: @cypress/schematic @cypress/schematic package issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants