fix: plugin file in angular schematics #17141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
@admah This should fix the broken release 1.4.0. We used to have integration tests in the briebug schematics to avoid these kinds of regressions. Are they running here? |
admah
requested review from
chrisbreiding and
kuceb
and removed request for
a team,
chrisbreiding and
kuceb
|
@cexbrayat thank you for reporting this and creating the PR. I definitely agree that we should have a test on the entire install process to avoid these types of issues in the future, and I will make sure that we have it in there. For this PR, it looks like there are 2 outstanding issues before I can approve/merge:
|
Runnin g`ng add @cypress/schematic --defaults --skip-confirmation` in a new Angular 12 application results in a broken setup for cypress, as the plugin file does not have any export. When running `ng e2e`, Cypress complains with: ``` The plugins file is missing or invalid. Your `pluginsFile` is set to `/Users/ced-pro/Code/angular/angular-cli-diff/ponyracer/cypress/plugins/index.js`, but either the file is missing, it contains a syntax error, or threw an error when required. The `pluginsFile` must be a `.js`, `.ts`, or `.coffee` file. Or you might have renamed the extension of your `pluginsFile`. If that's the case, restart the test runner. Please fix this, or set `pluginsFile` to `false` if a plugins file is not necessary for your project. ``` This commit reverts the changes to the plugin file made in 96a9db4 and fixes the issue.
cexbrayat
force-pushed
the
fix/plugin-index
branch
from
bb979d7
to
feb6a59
Compare
|
@admah 👌
|
admah
approved these changes
Jun 29, 2021
tgriesser
added a commit
that referenced
this pull request
Jun 29, 2021
* develop: fix: plugin file referenced by cypress config in angular schematics (#17143) refactor: @packages/runner-shared should also be devDependencies (#17133) chore: release @cypress/schematic-v1.4.1 fix: plugin file in angular schematics (#17141) chore(runner): render spec list inline (behind feature flag) (#17069) refactor: remove junk test (#17125) chore(server): collapse project-ct and project-e2e into project-base (#17115) chore: release @cypress/schematic-v1.4.0
tgriesser
added a commit
that referenced
this pull request
Jun 30, 2021
* develop: fix: prevent saved state errors for deprecated keys (#17093) fix(studio): restore intro modal styles (#17118) refactor: add @packages/resolve-dist to isolate client/server code (#17109) fix: plugin file referenced by cypress config in angular schematics (#17143) refactor: @packages/runner-shared should also be devDependencies (#17133) chore: release @cypress/schematic-v1.4.1 fix: plugin file in angular schematics (#17141) chore(runner): render spec list inline (behind feature flag) (#17069) refactor: remove junk test (#17125) chore(server): collapse project-ct and project-e2e into project-base (#17115) fix: make dev-server error message appear only once when CT is not configured (#17090) chore: release @cypress/schematic-v1.4.0 feat: add ng generate to @cypress/schematic to generate e2e spec files (#16962) feat(studio): add ability to copy commands to clipboard (#16912) chore: release @cypress/webpack-preprocessor-v5.9.1 chore: release @cypress/webpack-batteries-included-preprocessor-v2.2.2 chore: release @cypress/vue-v3.0.0-beta.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
Running
ng add @cypress/schematic --defaults --skip-confirmationin a new Angular 12 application results in a broken setup for cypress,as the plugin file does not have any export.
When running
ng e2e, Cypress complains with:This commit reverts the changes to the plugin file made in 96a9db4
and fixes the issue.