-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: improve React mountHook
type
#17241
Conversation
Thanks for taking the time to open a PR!
|
mountHook
type
LGTM, but you will need to ensure the CLA is signed before we can merge this: #17241 (comment). Seems you committed on an account that has not signed it (not a GH user account). PS: anything in |
Thanks @lmiller1990 ! I can wait 2 weeks, not problem. About CLA, I don't know why but I signed it twice but nothing change... |
@edimitchel CLA looks good now. 👍 |
But now some build fails even I didn't make any change.. Someone could replay the build ? |
@lmiller1990 tests are green ! |
I will get this merged up, nice job @edimitchel. 💯 |
Thank you @lmiller1990 ! My first contribution ! |
User facing changelog
Cypress React mount hook have correct types . Fixes #17236.
How has the user experience changed?
Improved types (example on
use-counter.spec.js
Before
After
PR Tasks
cypress-documentation
? None for the moment, but as I see, there is not documentation about themountHook
function