Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve React mountHook type #17241

Merged
merged 5 commits into from
Jul 12, 2021
Merged

Conversation

edimitchel
Copy link
Contributor

User facing changelog

Cypress React mount hook have correct types . Fixes #17236.

How has the user experience changed?

Improved types (example on use-counter.spec.js
Before
image

After
image

PR Tasks

  • Have tests been added/updated? Should I add tests ?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation? None for the moment, but as I see, there is not documentation about the mountHook function

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 7, 2021

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Jul 7, 2021

CLA assistant check
All committers have signed the CLA.

@edimitchel edimitchel changed the title feat(react) : improve mountHook types fix: improve React mountHook type Jul 7, 2021
lmiller1990
lmiller1990 previously approved these changes Jul 8, 2021
@lmiller1990
Copy link
Contributor

lmiller1990 commented Jul 8, 2021

LGTM, but you will need to ensure the CLA is signed before we can merge this: #17241 (comment). Seems you committed on an account that has not signed it (not a GH user account).

PS: anything in npm uses semantic release - released on merge to MASTER. So, if you want to remake this PR against master, it will be released sooner. Otherwise, it will wait for our 2 week release cycle.

@edimitchel
Copy link
Contributor Author

Thanks @lmiller1990 ! I can wait 2 weeks, not problem.

About CLA, I don't know why but I signed it twice but nothing change...

@jennifer-shehane
Copy link
Member

@edimitchel CLA looks good now. 👍

@edimitchel
Copy link
Contributor Author

But now some build fails even I didn't make any change.. Someone could replay the build ?

@edimitchel
Copy link
Contributor Author

@lmiller1990 tests are green !

@lmiller1990
Copy link
Contributor

I will get this merged up, nice job @edimitchel. 💯

@edimitchel
Copy link
Contributor Author

Thank you @lmiller1990 ! My first contribution !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mount hook types for React component testing are not right
4 participants