Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mouseover event is used on command log items causing too many renders #17257

Closed
kuceb opened this issue Jul 9, 2021 · 2 comments · Fixed by #17258
Closed

mouseover event is used on command log items causing too many renders #17257

kuceb opened this issue Jul 9, 2021 · 2 comments · Fixed by #17258
Labels

Comments

@kuceb
Copy link
Contributor

kuceb commented Jul 9, 2021

we use onMouseOver on each item in the command log to show dom snapshots for commands.

problem:
because mouseover bubbles, the event is triggered multiple times when a user hovers within the command, since inner dom nodes inside the command will bubble their mouseover to the outer dom node.

mouseeventbefore.mp4

solution:
use mouseenter, which doesn't bubble and mimics the behavior of a css :hover psuedo selector

mouseeventafter.mp4
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 16, 2021

The code for this is done in cypress-io/cypress#17258, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 20, 2021

Released in 8.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v8.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants