Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cypress/schematic): add reporter and reporter-options to builder schematic #17353

Merged
merged 4 commits into from
Jul 20, 2021
Merged

feat(cypress/schematic): add reporter and reporter-options to builder schematic #17353

merged 4 commits into from
Jul 20, 2021

Conversation

admah
Copy link
Contributor

@admah admah commented Jul 15, 2021

User facing changelog

  • adds reporter and reporterOptions to builder options in cypress/schematic

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 15, 2021

Thanks for taking the time to open a PR!

@linear
Copy link

linear bot commented Jul 15, 2021

DX-495 Add builder option for reporter

Per request #17312

  • Also add reporter-options

@admah admah requested review from a team and amirrustam July 15, 2021 16:40
@cypress
Copy link

cypress bot commented Jul 15, 2021 •
edited


Test summary

655 • 0 • 7 • 0 • Flakiness 0

Run details
Project cypress
Status Passed
Commit a5a24c8
Started Jul 20, 2021 4:26 PM
Ended Jul 20, 2021 4:35 PM
Duration 09:02 💡
OS Linux Debian - 10.8
Browser Electron 89

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@admah admah changed the title feat: add reporter and reporter-options to builder schematic feat(cypress/schematic): add reporter and reporter-options to builder schematic Jul 16, 2021
@admah admah added the npm: @cypress/schematic @cypress/schematic package issues label Jul 16, 2021
jaffrepaul
jaffrepaul approved these changes Jul 20, 2021
View reviewed changes
Copy link
Member

@jaffrepaul jaffrepaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@admah admah merged commit b7783e6 into master Jul 20, 2021
@cypress-bot cypress-bot bot mentioned this pull request Jul 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaffrepaul jaffrepaul jaffrepaul approved these changes

@amirrustam amirrustam Awaiting requested review from amirrustam

Assignees
No one assigned
Labels
npm: @cypress/schematic @cypress/schematic package issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@admah @jaffrepaul