Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: merging / delegating remote queries to cloud schema #17875

Merged
merged 33 commits into from
Sep 20, 2021
Merged

feat: merging / delegating remote queries to cloud schema #17875

merged 33 commits into from
Sep 20, 2021

Conversation

tgriesser
Copy link
Member

@tgriesser tgriesser commented Aug 25, 2021 •
edited

Changes:

  • Pulls down & stitches in the "Cypress Cloud" schema from remote. Currently defaulted to "staging" so we can make quick fixes / iteration there
  • Add dedicated type checking CircleCI job check-ts
  • Adds graphcache to normalize the cache & provide better auto-reactivity when data changes
  • Removes LocalProject / DashboardProject in favor of Project / CloudProject
  • General cleanup of Vue components' GraphQL fragments
  • Parallelizes launchpad tests & recording to new Cypress project: https://dashboard.cypress.io/projects/sehy69/runs
    • Did this b/c tests were frequently timing out, need to figure out the source of this
  • Basic mocks for remote schema

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 25, 2021

Thanks for taking the time to open a PR!

@tgriesser
WIP: basic queries running against services
efeb4d3
@tgriesser
WIP on vue integration layer
a30c904
@tgriesser
Merge branch 'unified-desktop-gui' into tgriesser/feat/unified-deskto…
c8bc48d 
…p-gui-gql-stitching

* unified-desktop-gui:
  fix: rename testApolloClient -> testUrqlClient, add apollo.config.js (#17948)
  feat(launchpad): detect if runner is set up and change UI accordingly (#17934)
  rebuild yarn lock
  chore: remove skipLibCheck, re-add vue-tsc, fix types (#17924)
  fix: ensure @headlessui/vue is bundled
  chore(graphql): make tsconfig more strict (#17909)
  run vite during watch
  fix: source maps while developing electron
  rebuild schema w/o JS files
  make constant more generic
  remove hanging tests
  allow larger artifacts
  comment out flaky test
  fix typing errors
  make graphql tsconfig more minimal
  chore: use `import type` syntax (#17864)
  remove browser-specific `beforeinput` checks (send in firefox) (#17820)
  fix(types): Update title method options type (#17781)
  fix(deps): update dependency @cypress/request to v2.88.6 🌟 (#17813)
@tgriesser
Merge branch 'unified-desktop-gui' into tgriesser/feat/unified-deskto…
90a8b99 
…p-gui-gql-stitching

* unified-desktop-gui: (26 commits)
  pin vite, add --no-bail to lerna build
  fix: add warning for check/uncheck when values passed with elements with no values (#17925)
  chore: Update Chrome (stable) to 93.0.4577.63 and Chrome (beta) to 94.0.4606.31 (#17910)
  feat: log args separately. (#17650)
  fix(server): Fix EACCES on extension installation if copied from read-only location (#17800)
  chore: converting packages/driver to be esm
  Rename driver files to TS
  chore: Don't include tooltips in reporter percy snapshots (#18007)
  chore: Fix chrome jobs in CI (#18005)
  docs: Add readmes to packages that are missing Readmes (#17937)
  chore: Prevent unnecessary files from being included in the binary (#17957)
  fix(launchpad): update wizard navigation (#17954)
  chore: remove unused @packages/static (#17961)
  chore: use command to ensure chrome version exists (#17955)
  chore: fix project-ct + server-ct type imports (#17953)
  feat: add `decode` option to `cy.url` (#17930)
  fix: match `Cypress.dom.getElementPositioning` implementation to the declared type signature by actually accepting native `HTMLElement` (#17914)
  fix: `Cypress.testingType` should not be `undefined`. (#17931)
  improve types
  chore: rename open_project to ts
  ...
@tgriesser
fixes
4eb2433
@tgriesser
Merge branch 'unified-desktop-gui' into tgriesser/feat/unified-deskto…
89b0b1d 
…p-gui-gql-stitching

* unified-desktop-gui:
  fix: Global Mode Crashes on Launch (#18059)
  fix(launchpad): add a11y support to Settings Card (#18027)
  fix transient dep problem
  fix(vite-dev-server): remove base and root from inlineVitConfig types (#17180)
  chore: adding the new app package for the unified app experience (#18053)
  feat: allow usage of @react/plugins with cypress.config.js (#17738)
  rename inject into devServer
  fix: add missing clientCertificate type to ResolvedConfigOptions (#18028)
  docs: restore author of react,vue,ng component testing (#16800)
  fix(cypress/schematic): add edge to list of allowed browsers (#17637)
  fix: global hooks cause duplicated hooks after domain navigation (#17884)
  chore: release @cypress/webpack-dev-server-v1.5.0
  chore: release @cypress/vite-dev-server-v2.0.8
@tgriesser
feat: better schema stitching, wip on better DX
ec69e69
@tgriesser
Merge branch 'unified-desktop-gui' into tgriesser/feat/unified-deskto…
d1ac2e2 
…p-gui-gql-stitching

* unified-desktop-gui:
  remove unused file
  remove old codegen
  remove built js file
  remove old files
  remove exports
  chore: removing ipc layer from launchpad to make it testable over http (#18065)
  use debug instead of console.log
  bump yarn lock
  remove all references to server-ct
  remove server-ct package
  move server-ct initialize logic to server
  update imports
  move files from server-ct to server
@tgriesser
updates
34ea736
@tgriesser
Merge
6a5f95e
@tgriesser tgriesser changed the title WIP: merging / delegating remote queries to cloud schema feat: merging / delegating remote queries to cloud schema Sep 15, 2021
@tgriesser
Merge branch 'unified-desktop-gui' into tgriesser/feat/unified-deskto…
9a49147 
…p-gui-gql-stitching

* unified-desktop-gui:
  feat: improved DX for unified-desktop-gui (#18099)
  chore: merge in develop to unified-desktop-gui (#18103)
  bump to Vue 3.2.6 (#18098)
  feat: add state for global mode (#18085)
  fix: add @vue/compiler-sfc to fix dev errors (#18096)
  feat(launchpad): Browser launch screen UI (#18095)
  chore: add frontend-shared package (#18089)
  chore(launchpad): launch e2e runner, perf improvements (#18073)
  add missing file
  fix: move dependencies to devDependencies to fix create-build-artifacts package size guard (#18081)
@tgriesser
chore: remove codegen
94f1b4d
@tgriesser
more wip
8b2c1c7
@tgriesser
better type-checking, add graphcache
501821e
@tgriesser
remove LocalProject
3f28d00
@tgriesser
fix: run buildProd at in the build step
f575902
@tgriesser
fix env var
0254434
@tgriesser tgriesser mentioned this pull request Sep 16, 2021
Closed
@tgriesser tgriesser marked this pull request as ready for review September 17, 2021 13:00
@tgriesser tgriesser requested a review from a team as a code owner September 17, 2021 13:00
@tgriesser tgriesser requested review from chrisbreiding and kuceb and removed request for a team September 17, 2021 13:00
@ImCesar ImCesar mentioned this pull request Sep 17, 2021
Merged
lmiller1990
lmiller1990 reviewed Sep 20, 2021
View reviewed changes
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Asked some q's, mostly makes sense. I'll try and run this locally, but I think I'll need some help to set up services at some point, too.

graphql-codegen.yml Show resolved Hide resolved
packages/graphql/schemas/cloud.graphql Show resolved Hide resolved
packages/graphql/src/entities/Query.ts Outdated Show resolved Hide resolved
packages/graphql/src/schema.ts Outdated Show resolved Hide resolved
packages/launchpad/src/App.vue Show resolved Hide resolved
@tgriesser tgriesser merged commit 94541d4 into unified-desktop-gui Sep 20, 2021
@tgriesser tgriesser deleted the tgriesser/feat/unified-desktop-gui-gql-stitching branch September 20, 2021 21:13
@tgriesser tgriesser mentioned this pull request Sep 21, 2021
Closed
@lmiller1990 lmiller1990 mentioned this pull request Sep 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmiller1990 lmiller1990 lmiller1990 left review comments

@JessicaSachs JessicaSachs Awaiting requested review from JessicaSachs

@chrisbreiding chrisbreiding Awaiting requested review from chrisbreiding

@kuceb kuceb Awaiting requested review from kuceb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tgriesser @lmiller1990