Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome processes are not always being killed on Cypress exit #18002

Closed
muhammad-st opened this issue Sep 7, 2021 · 3 comments
Closed

Chrome processes are not always being killed on Cypress exit #18002

muhammad-st opened this issue Sep 7, 2021 · 3 comments
Labels
stale no activity on this issue for a long period

Comments

@muhammad-st
Copy link

muhammad-st commented Sep 7, 2021

Current behavior

If chrome was unresponsive at the time Cypress exited, Chrome processes will not be killed/closed.

Desired behavior

chrome processes should be killed with -9 after a timeout if they were unresponsive at the time of Cypress exit.

Test code to reproduce

  • Run a spec that gets chrome busy/frozen (see example below).
  • kill cypress with SIGINT. (as if killed due to timeout by Jenkins)
  • chrome process will detach and stay there forever.

Example Scenario

describe('big file spec', () => {
  it('should fail', () => {
    cy.visit('https://www.google.com');
    cy.writeFile('./text.txt', 'x'.repeat(100*1024*1024));
  });
});

To make sure this is making chrome busy, open inspector (while using headed mode) and try to inspect the packets in Cypress's WebSocket connections, chrome will freeze (as mentioned in #17903).

Cypress Version

8.3.0

Other

No response

@muhammad-st
Copy link
Author

@jennifer-shehane Have you had the time to look into this?

@cypress-app-bot
Copy link
Collaborator

This issue has not had any activity in 180 days. Cypress evolves quickly and the reported behavior should be tested on the latest version of Cypress to verify the behavior is still occurring. It will be closed in 14 days if no updates are provided.

@cypress-app-bot cypress-app-bot added the stale no activity on this issue for a long period label May 15, 2023
@cypress-app-bot
Copy link
Collaborator

This issue has been closed due to inactivity.

@cypress-app-bot cypress-app-bot closed this as not planned Won't fix, can't repro, duplicate, stale Jun 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale no activity on this issue for a long period
Projects
None yet
Development

No branches or pull requests

2 participants