Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on [Cannot create property 'Symbol(ERR_PREPARED_FOR_SERIALIZATION)' on boolean 'true'] #19561

Closed
Arcturus5404 opened this issue Jan 5, 2022 · 5 comments · Fixed by #20172
Labels

Comments

@Arcturus5404
Copy link

Current behavior

Currently some of our tests sometimes fail on
Cannot create property 'Symbol(ERR_PREPARED_FOR_SERIALIZATION)' on boolean 'true'

It seems like the error itself is swallowed somehow? or there is no error to begin with and there is something wrong with the error parsing?

Desired behavior

No to fail the tests, and log a helpful error message

Test code to reproduce

No idea how to reproduce this. We have cypress dashboard; those are the tests that are flaky right now.

Cypress Version

9.2.0

Other

No response

@mjhenkes
Copy link
Member

mjhenkes commented Jan 6, 2022

It's likely that through some method the boolean true is being being thrown which causes our error serialization to fail itself here

We could handle boolean errors similar to how we handle strings here, but it's still unclear where and how 'true' is being thrown

@mjhenkes mjhenkes added type: bug stage: ready for work The issue is reproducible and in scope labels Jan 6, 2022
@rafinskipg
Copy link

i'm getting this error too, and i don't understand why

@Arcturus5404
Copy link
Author

I think it is because some Promise is rejecting with value true which is uncaught

@cypress-bot cypress-bot bot added stage: backlog and removed stage: ready for work The issue is reproducible and in scope labels Jan 14, 2022
@jennifer-shehane jennifer-shehane added good first issue Good for newcomers stage: ready for work The issue is reproducible and in scope and removed stage: backlog labels Jan 14, 2022
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope labels Feb 14, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 16, 2022

The code for this is done in cypress-io/cypress#20172, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Feb 16, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 28, 2022

Released in 9.5.1.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v9.5.1, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants