Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update scaffold template to use correct path #20047

Merged
merged 12 commits into from
Feb 7, 2022
Merged

fix: update scaffold template to use correct path #20047

merged 12 commits into from
Feb 7, 2022

Conversation

estrada9166
Copy link
Member

@estrada9166 estrada9166 commented Feb 4, 2022 •
edited

User facing changelog

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 4, 2022

Thanks for taking the time to open a PR!

@estrada9166 estrada9166 marked this pull request as draft February 4, 2022 02:09
@estrada9166 estrada9166 marked this pull request as ready for review February 4, 2022 14:44
@cypress
Copy link

cypress bot commented Feb 4, 2022 •
edited


Test summary

17929 • 0 • 211 • 0 • Flakiness 2

Run details
Project cypress
Status Passed
Commit cf44273
Started Feb 7, 2022 8:09 PM
Ended Feb 7, 2022 8:21 PM
Duration 12:01 💡
OS Linux Debian - 10.10
Browser Multiple

View run in Cypress Dashboard ➡️

Flakiness

commands/net_stubbing.cy.ts 1 Flakiness
1 network stubbing > waiting and aliasing > can timeout waiting on a single request using "alias.request"
cypress/proxy-logging.cy.ts 1 Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cowboy
cowboy suggested changes Feb 4, 2022
View reviewed changes
cli/types/cypress.d.ts Outdated Show resolved Hide resolved
packages/server/lib/plugins/child/run_require_async_child.js Outdated Show resolved Hide resolved
system-tests/__snapshots__/devServer_dynamic_support.ts.js Outdated Show resolved Hide resolved
lmiller1990
lmiller1990 previously approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code seems generally fine, will need to make sure the error messages are consistent as noted by @cowboy

packages/server/lib/plugins/child/run_require_async_child.js Outdated Show resolved Hide resolved
cowboy
cowboy suggested changes Feb 7, 2022
View reviewed changes
packages/server/lib/errors.js Outdated Show resolved Hide resolved
cowboy
cowboy suggested changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@cowboy cowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last change, sorry I missed it earlier!

packages/server/lib/errors.js Outdated Show resolved Hide resolved
cowboy
cowboy approved these changes Feb 7, 2022
View reviewed changes
Copy link
Contributor

@cowboy cowboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@estrada9166 estrada9166 changed the title fix: update scaffold template to use correct path fix: update scaffold template to use correct path. Feb 7, 2022
@estrada9166 estrada9166 changed the title fix: update scaffold template to use correct path. fix: update scaffold template to use correct path Feb 7, 2022
@estrada9166 estrada9166 merged commit 6e80359 into 10.0-release Feb 7, 2022
@estrada9166 estrada9166 deleted the alejandro/fix/update-scaffold-template branch February 7, 2022 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cowboy cowboy cowboy approved these changes

@tgriesser tgriesser Awaiting requested review from tgriesser

@lmiller1990 lmiller1990 Awaiting requested review from lmiller1990

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@estrada9166 @cowboy @lmiller1990