Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: display cy.mount command log #21500

Merged
merged 4 commits into from
May 17, 2022

Conversation

estrada9166
Copy link
Member

User facing changelog

Update vue2 to log the mount command, it was previously not being logged as we do for the different frameworks

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 13, 2022

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented May 13, 2022



Test summary

4843 1 59 0Flakiness 4


Run details

Project cypress
Status Failed
Commit 8e44196
Started May 16, 2022 8:54 PM
Ended May 16, 2022 9:17 PM
Duration 22:52 💡
OS Linux Debian - 10.10
Browser Electron 94

View run in Cypress Dashboard ➡️


Failures

cypress/e2e/commands/files.cy.js Failed
1 ... > has implicit existence assertion, retries and throws a specific error when file does not exist for null encoding

Flakiness

commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse
e2e/origin/commands/waiting.cy.ts Flakiness
1 cy.origin waiting > #consoleProps > .wait()
cypress/proxy-logging.cy.ts Flakiness
1 Proxy Logging > request logging > xhr log has response body/status code when xhr response is logged second
e2e/origin/commands/querying_shadow.cy.ts Flakiness
1 cy.origin shadow dom > #consoleProps > .shadow()

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@estrada9166 estrada9166 marked this pull request as ready for review May 13, 2022 21:05
@estrada9166 estrada9166 requested a review from a team as a code owner May 13, 2022 21:05
@estrada9166 estrada9166 requested review from ZachJW34 and tbiethman and removed request for a team May 13, 2022 21:05
const fileName = filepathSplit[filepathSplit.length - 1]

// remove the extension .js, .ts or .vue from the filename to get the name of the component
const baseFileName = fileName.replace(/\.(js|ts|vue)?$/, '')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If filepathSplit does not have a /, fileName will be undefined, then we will get "Cannot call replace on undefined" here.

I think we need

const fileName = filepathSplit[filepathSplit.length - 1] ?? DEFAULT_COMP_NAME

Copy link
Contributor

@ZachJW34 ZachJW34 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lmiller1990 lmiller1990 merged commit 140b4ba into 10.0-release May 17, 2022
@lmiller1990 lmiller1990 deleted the alejandro/fix/display-mount-log branch May 17, 2022 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants