Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress/schematic): run configuration does not work anymore without baseUrl #21629

Merged
merged 4 commits into from
Jul 22, 2022

Conversation

admah
Copy link
Contributor

@admah admah commented May 25, 2022

Fixes #21555.

Users can now add custom options to devServerTarget in angular.json to specify baseUrl:

"options": {
  "host": "localhost",
  "port": 4200
},

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 25, 2022

Thanks for taking the time to open a PR!

@linear
Copy link

linear bot commented May 25, 2022

DX-948

@admah admah changed the title fix(2 fix(cypress/schematic): run configuration does not work anymore without baseUrl May 25, 2022
@admah admah marked this pull request as ready for review May 25, 2022 16:15
@admah admah requested a review from a team as a code owner May 25, 2022 16:15
@admah admah requested review from ZachJW34 and jordanpowell88 and removed request for a team May 25, 2022 16:15
@cypress
Copy link

cypress bot commented May 25, 2022



Test summary

4378 0 49 0Flakiness 0


Run details

Project cypress
Status Passed
Commit a068278
Started Jul 22, 2022 9:50 PM
Ended Jul 22, 2022 10:02 PM
Duration 12:26 💡
OS Linux Debian - 10.11
Browser Electron 100

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@admah admah requested a review from ZachJW34 July 22, 2022 15:22
@admah
Copy link
Contributor Author

admah commented Jul 22, 2022

@ZachJW34 what do we typically do when the Percy tests fail? Nothing I touched should have altered those in any way.

@ZachJW34
Copy link
Contributor

@admah Your changes have no impact on UI so we can ignore the Percy diffs. I reran the build that flaked, so let's get this merged once everything (besides Percy) is green

@ZachJW34 ZachJW34 merged commit 3ed93e1 into master Jul 22, 2022
@ZachJW34 ZachJW34 deleted the dx-948-fix-baseurl-issue branch July 22, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants