fix: add package.json metadata for webpack-dev-server #22292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
ZachJW34
changed the title
flotwig
reviewed
Jun 13, 2022
| "license": "MIT", | ||
| "repository": { | ||
| "type": "git", | ||
| "url": "https://github.com/cypress-io/cypress.git" |
There was a problem hiding this comment.
oh, @ryanthemanuel i bet this is why we were getting "authenticity cannot be established" - we were using git+ssh, and having repository.url set can force npm to use https instead, avoiding known_hosts verification. kudos @ZachJW34 for actually tracking this down
There was a problem hiding this comment.
although i don't think you were touching these files when you first ran into it 😕
There was a problem hiding this comment.
Glad I could (unknowingly) help 😅
flotwig
approved these changes
Jun 13, 2022
mjhenkes
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
na
Additional details
npm-release is timing out on
@cypress/webpack-dev-server. It is failing withThe package.json for
@cypress/webpack-dev-serveris missing some required fields. It used to have these but we dropped them when doing the overhaul. I tested this change by ssh-ing into the npm-release job and verifying that it was able to move past this timeout.I also removed the configured registry for
@cypress/vue2as we have had issues in the past releasing a package configured with thehttp://since it's deprecated in favor ofhttps://which is the default value.Steps to test
Job shows what's going on, I was only able to reproduce it on the CI machine
How has the user experience changed?
na
PR Tasks
cypress-documentation?type definitions?