Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address skipped tests in settings_spec in server package #22493

Open
astone123 opened this issue Jun 23, 2022 · 0 comments
Open

Address skipped tests in settings_spec in server package #22493

astone123 opened this issue Jun 23, 2022 · 0 comments
Labels
process: tests Related to our internal tests Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: chore Work is required w/ no deliverable to end user

Comments

@astone123
Copy link
Contributor

astone123 commented Jun 23, 2022 •
edited

All/most of the tests in the following file are disabled

https://github.com/cypress-io/cypress/blob/110f8ae02dd2b6fd695856aaa77e3b9d96c939dc/packages/server/test/unit/util/settings_spec.js#L13%7Csmart-link

We need to make sure that this coverage exists somewhere and if it doesn't create those tests and delete these ones. If the tests are completely irrelevant then they need to be deleted.

This issue resulted from #22356
@astone123 astone123 changed the title Address skipped tests in preprocessor_spec in server package Address skipped tests in settings_spec in server package Jun 23, 2022
@mjhenkes mjhenkes added the CT Issue related to component testing label Jun 23, 2022
@nagash77 nagash77 added routed-to-ct Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. and removed routed-to-ct labels Apr 13, 2023
@jennifer-shehane jennifer-shehane added process: tests Related to our internal tests and removed stage: routed to ct labels Nov 21, 2023
@jennifer-shehane jennifer-shehane added type: chore Work is required w/ no deliverable to end user and removed CT Issue related to component testing labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
process: tests Related to our internal tests Triaged Issue has been routed to backlog. This is not a commitment to have it prioritized by the team. type: chore Work is required w/ no deliverable to end user
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@nagash77 @jennifer-shehane @mjhenkes @mschile @astone123