Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for cross origin cookie handling for other resource types when experimentalSessionAndOrigin is enabled #22952

Closed
AtofStryker opened this issue Jul 27, 2022 · 3 comments · Fixed by #22963
Closed

Allow for cross origin cookie handling for other resource types when experimentalSessionAndOrigin is enabled #22952

AtofStryker opened this issue Jul 27, 2022 · 3 comments · Fixed by #22963
Assignees
@mschile
Labels
topic: cy.origin Problems or enhancements related to cy.origin command type: enhancement Requested enhancement of existing feature

Comments

@AtofStryker
Copy link
Contributor

What would you like?

Cypress, when using experimentalSessionAndOrigin, only handles cross origin cookies if the request comes from the AUT Frame. This only includes requests made by the Document in the AUT and not XHR or other types of requests that may also need cross origin handling.

We would like to see cookie handling applied to other resource types coming from the AUT, likely including XHR and Fetch resource types (and possibly others).

Why is this needed?

Currently, users are unable to log into Google due to cookie mismatches after signing in. This is due to cookies not being sent with the XHR request. This also should apply the cookie logic more consistently to behave more like the browser.

Other

No response
@AtofStryker
Copy link
Contributor Author

possibly related to #22882

@AtofStryker AtofStryker added topic: cy.origin Problems or enhancements related to cy.origin command type: enhancement Requested enhancement of existing feature labels Jul 27, 2022
@mjhenkes mjhenkes mentioned this issue Jul 27, 2022
Closed
@mschile mschile mentioned this issue Jul 27, 2022
Merged
2 tasks
@cypress-bot cypress-bot bot added stage: needs review The PR code is done & tested, needs review and removed stage: routed to e2e-auth labels Jul 27, 2022
@cypress-bot cypress-bot bot added stage: pending release and removed stage: needs review The PR code is done & tested, needs review labels Jul 29, 2022
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 29, 2022

The code for this is done in cypress-io/cypress#22963, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 2, 2022

Released in 10.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v10.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mschile mschile

Labels
topic: cy.origin Problems or enhancements related to cy.origin command type: enhancement Requested enhancement of existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Remove isAUTFrame qualification from cross origin cookie check cypress-io/cypress
2 participants
@mschile @AtofStryker