-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use legacy-peer-deps for semantic-release process #23231
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here's hoping! 😸
@ZachJW34 Do you have a link to the broken job? |
@emilyrohrbough updated the description with a link to the latest master build, I tried to fix it last week. All |
Could you update the script to perform a dry-run and test on this branch it provides the correct dry-run output? |
@emilyrohrbough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's give it a try
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
User facing changelog
na
Additional details
The
npm-release
job is broken due to peer-dependency issues. Before reverting the semantic-release dep (which has security implications), I'd like to try theNPM_CONFIG_LEGACY_PEER_DEPS
option.Link to latest master
npm-release
failure: https://app.circleci.com/pipelines/github/cypress-io/cypress/41450/workflows/e56453d4-5d77-4e96-8262-82517d9668aa/jobs/1716530Steps to test
I have no good way to test this since semantic-release requires valid npm_tokens. The build is failing when running
npm version
but I can't reproduce this locally.How has the user experience changed?
na
PR Tasks
cypress-documentation
?type definitions
?