Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use legacy-peer-deps for semantic-release process #23231

Merged
merged 2 commits into from
Aug 9, 2022

Conversation

ZachJW34
Copy link
Contributor

@ZachJW34 ZachJW34 commented Aug 9, 2022

User facing changelog

na

Additional details

The npm-release job is broken due to peer-dependency issues. Before reverting the semantic-release dep (which has security implications), I'd like to try the NPM_CONFIG_LEGACY_PEER_DEPS option.

Link to latest master npm-release failure: https://app.circleci.com/pipelines/github/cypress-io/cypress/41450/workflows/e56453d4-5d77-4e96-8262-82517d9668aa/jobs/1716530

Steps to test

I have no good way to test this since semantic-release requires valid npm_tokens. The build is failing when running npm version but I can't reproduce this locally.

How has the user experience changed?

na

PR Tasks

  • [na] Have tests been added/updated?
  • [na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?

@ZachJW34 ZachJW34 requested a review from a team as a code owner August 9, 2022 22:31
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 9, 2022

Thanks for taking the time to open a PR!

@ZachJW34 ZachJW34 changed the title Merge pull request #23065 from cypress-io/develop fix: use legacy-peer-deps for semantic-release process Aug 9, 2022
Copy link
Contributor

@rachelruderman rachelruderman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's hoping! 😸

@emilyrohrbough
Copy link
Member

@ZachJW34 Do you have a link to the broken job?

@ZachJW34
Copy link
Contributor Author

ZachJW34 commented Aug 9, 2022

@emilyrohrbough updated the description with a link to the latest master build, I tried to fix it last week. All npm-release builds since the semantic-release bump have been failing (at least, the jobs that actually detect packages to publish)

@emilyrohrbough
Copy link
Member

I have no good way to test this since semantic-release requires valid npm_tokens. The build is failing when running npm version but I can't reproduce this locally.

Could you update the script to perform a dry-run and test on this branch it provides the correct dry-run output?
https://github.com/semantic-release/semantic-release/blob/master/cli.js#L37

@ZachJW34
Copy link
Contributor Author

ZachJW34 commented Aug 9, 2022

@emilyrohrbough --dry-run passes locally, but it skips the semantic-release steps that are actually throwing the error
Screen Shot 2022-08-09 at 5 42 23 PM

Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's give it a try

@ZachJW34 ZachJW34 requested a review from a team as a code owner August 9, 2022 22:49
@cypress
Copy link

cypress bot commented Aug 9, 2022



Test summary

37828 0 473 0Flakiness 12


Run details

Project cypress
Status Passed
Commit 536e5cf
Started Aug 9, 2022 10:56 PM
Ended Aug 9, 2022 11:14 PM
Duration 17:50 💡
OS Linux Debian - 11.3
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/e2e/commands/xhr.cy.js Flakiness
1 ... > logs request + response headers
2 ... > logs Method, Status, URL, and XHR
3 ... > logs request + response headers
4 ... > logs Method, Status, URL, and XHR
5 ... > logs response
This comment includes only the first 5 flaky tests. See all 12 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ZachJW34 ZachJW34 merged commit 1a354b2 into master Aug 9, 2022
@ZachJW34 ZachJW34 deleted the zachw/fix-semantic-release-legacy-peer-deps branch August 9, 2022 23:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants