fix: remove webpack entrypoints from for ct webpack projects

[ZachJW34]

• Closes Components testing - Webpack entry feature causes confusion #23224

User facing changelog

Webpack entrypoints are no longer preserved for CT Webpack projects

Additional details

Fixes a regression from #22314 where webpack entrypoints were being preserved. This is mostly a revert of the changes made to entrypoints in that PR. It made sense for frameworks as their was logic added for removing entrypoints that would cause problems in each handler, but users who pass in a custom webpack config (don't use a higher-order framework like Next or create-react-app) were facing issues with their entrypoint being included and executed.

Steps to test

Checkout the repo provided in the original issue: https://gitlab.com/souf/react-webpack-playground/-/tree/cypress-webpack-entry

Install Cypress and walk through CT setup.

Create a simple spec:

// src/components/App.cy.jsx
import React from "react";
import App from "./App";

it("should render", () => {
  cy.mount(<App />);
});

Then run the spec. Nothing will load, and the console will display:

Checkout my branch and run yarn workspace @cypress/webpack-dev-server build && yarn cypress:open. Open the same project and no more error!

How has the user experience changed?

Screen.Recording.2022-08-11.at.5.15.33.PM.mov

PR Tasks

• Have tests been added/updated?
• Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[lmiller1990]

One question/comment. This must go in the next release!

[lmiller1990]

Instead of deleting it in many places, and then having to remember this if we implement a new webpack handler, any chance we could lift this up higher and do something like

if (!angular) {
  delete webpackConfig.entry
}

Thoughts?

[ZachJW34]

This PR is doing exactly that. In #22314 I moved entry handling to each handler. This PR reverts those changes so that the handlers don't have to worry about entrypoints since they will be replaced with the Cypress entry here

The line you referenced is a removal, not an addition (unless I'm misunderstanding your comment)

[astone123]

I tested this with the example project and these changes resolve the webpack entrypoint issue 👍🏻