fix: force Webpack to emit assets on error #23844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astone123
requested review from
warrensplayer,
mike-plummer,
lmiller1990,
ZachJW34 and
rockindahizzy
|
Thanks for taking the time to open a PR!
|
|
Test summaryRun details
View run in Cypress Dashboard ➡️ Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||
ZachJW34
reviewed
Sep 15, 2022
ZachJW34
reviewed
Sep 15, 2022
npm/webpack-dev-server/__snapshots__/makeWebpackConfig.spec.ts.js
Outdated
Show resolved
Hide resolved
lmiller1990
reviewed
Sep 16, 2022
lmiller1990
reviewed
Sep 16, 2022
lmiller1990
reviewed
Sep 16, 2022
Co-authored-by: Zachary Williams <ZachJW34@gmail.com>
Co-authored-by: Stokes Player <stokes@cypress.io>
astone123
commented
Sep 16, 2022
| }, | ||
| devServerEvents: new EventEmitter(), | ||
| } | ||
| const actual = await makeWebpackConfig({ | ||
| devServerConfig, | ||
| sourceWebpackModulesResult: createModuleMatrixResult({ | ||
| webpack: 4, | ||
| webpack: 5, |
There was a problem hiding this comment.
This should be 5, not 4, since webpack-dev-server v4 uses Webpack 5. Confused yet?
astone123
commented
Sep 16, 2022
| }, | ||
| devServerEvents: new EventEmitter(), | ||
| } | ||
| const actual = await makeWebpackConfig({ | ||
| devServerConfig, | ||
| sourceWebpackModulesResult: sourceDefaultWebpackDependencies(devServerConfig), | ||
| sourceWebpackModulesResult: createModuleMatrixResult({ |
There was a problem hiding this comment.
Updated this to use createModuleMatrixResult, because we claim to be testing webpack-dev-server v3 in this test, but the version of Webpack was getting resolved to v5, when it should be v4.
ZachJW34
approved these changes
Sep 16, 2022
rockindahizzy
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Compile errors will now be surfaced in the command log during testing for Angular and Next projects
Additional details
Some frameworks (Angular and Next) configure Webpack to not emit assets that have errored. So, if there's a compile error during development in these projects, instead of serving the module that has the compilation error and throwing it, Webpack serves the successful asset from the previous build. The result is that the compilation error only appears in the console, and our command log and AUT look fine - as if nothing has happened.
This behavior is undesirable because if there is a compilation error, we want to fail the test and make the user aware. This PR adds
emitOnErrors: true(noEmitOnErrors: falsefor Webpack 4) to our default Webpack configuration to override these values and force Webpack to emit modules even when there is an error regardless of the framework configuration.Steps to test
makeDefaultWebpackConfig.tsangular.cy.tsandnext.cy.tsinnpm/webpack-dev-servermakeDefaultWebpackConfig.tsback and repeat step 2PR Tasks
cypress-documentation?type definitions?