Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(breaking): exclude node_modules from cross-origin-callback-loader #24952

Merged
merged 4 commits into from
Dec 2, 2022

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 2, 2022

  • Closes n/a

User facing changelog

  • cy.origin dependencies within a third-party plugin is no longer supported.

Additional details

Previously we were including node_modules when scanning for cy.origin dependencies to ensure any third party plugins/imports would be properly loaded. However, this caused large memory spikes and performance degradation when parsing files with large dependency graphs. Thus, we are going to exclude node_modules until we can come up with a more optimized solution.

Steps to test

The added system test uses a cy.origin dependency within a node_modules plugin and now fails.

How has the user experience changed?

  • cy.origin dependencies within a third-party plugin will no longer work.

Screen Shot 2022-12-02 at 12 11 54 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [Not Yet] Has a PR for user-facing changes been opened in cypress-documentation?
  • [n/a] Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 2, 2022

Thanks for taking the time to open a PR!

Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
@mjhenkes mjhenkes self-requested a review December 2, 2022 19:32
@cypress
Copy link

cypress bot commented Dec 2, 2022



Test summary

21730 0 1716 0Flakiness 4


Run details

Project cypress
Status Passed
Commit 0d35dc1
Started Dec 2, 2022 8:12 PM
Ended Dec 2, 2022 8:31 PM
Duration 19:36 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress-origin-communicator.cy.ts Flakiness
1 Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution
cypress-in-cypress-run-mode.cy.ts Flakiness
1 Cypress In Cypress - run mode > e2e run mode spec runner header is correct
2 Cypress In Cypress - run mode > hides reporter when NO_COMMAND_LOG is set in run mode
next.cy.ts Flakiness
1 Working with next-12 > should show compilation errors on src changes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Co-authored-by: Ryan Manuel <ryanm@cypress.io>
@mjhenkes mjhenkes merged commit 27c425d into release/12.0.0 Dec 2, 2022
@mjhenkes mjhenkes deleted the mschile/exclude_node_modules branch December 2, 2022 20:32
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 6, 2022

Released in 12.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants