Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands UI assert errors should clearly delineate integers from strings. #25

Closed
jennifer-shehane opened this issue Apr 20, 2015 · 4 comments · Fixed by #5619 · May be fixed by ngChile/ngx-devkit-cypress-builder#20 or qsays/grafana#1
Labels
good first issue Good for newcomers pkg/driver This is due to an issue in the packages/driver directory type: bug type: error message

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Apr 20, 2015

The ASSERT error (in red background) on the commands UI does not signify whether my value is a string or not. The AssertionError (in yellow background) more clearly defines my error (that the integer 25 does not equal "25").

Example
screen shot 2015-04-20 at 11 57 25 am

To reproduce:

it('test', () => {
  expect(25).to.eq('25')
})
@jennifer-shehane jennifer-shehane added this to the 0.17.x milestone Sep 30, 2016
@jennifer-shehane jennifer-shehane removed this from the 0.17.x milestone Feb 3, 2017
@verheyenkoen

This comment has been minimized.

@jennifer-shehane jennifer-shehane added good first issue Good for newcomers pkg/driver This is due to an issue in the packages/driver directory stage: ready for work The issue is reproducible and in scope labels Oct 27, 2017
@cypress-bot cypress-bot bot added stage: work in progress stage: ready for work The issue is reproducible and in scope and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Oct 30, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: ready for work The issue is reproducible and in scope and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Oct 31, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: ready for work The issue is reproducible and in scope and removed stage: ready for work The issue is reproducible and in scope stage: work in progress labels Oct 31, 2019
@cypress-bot cypress-bot bot added stage: work in progress stage: needs review The PR code is done & tested, needs review and removed stage: ready for work The issue is reproducible and in scope labels Nov 7, 2019
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 12, 2019

The code for this is done in cypress-io/cypress#5619, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

1 similar comment
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 12, 2019

The code for this is done in cypress-io/cypress#5619, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 27, 2019

Released in 3.7.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.