Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands UI assert errors should clearly delineate integers from strings. #25

Closed
jennifer-shehane opened this issue Apr 20, 2015 · 4 comments · Fixed by #5619

Comments

@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Apr 20, 2015

The ASSERT error (in red background) on the commands UI does not signify whether my value is a string or not. The AssertionError (in yellow background) more clearly defines my error (that the integer 25 does not equal "25").

Example
screen shot 2015-04-20 at 11 57 25 am

To reproduce:

it('test', () => {
  expect(25).to.eq('25')
})
@jennifer-shehane jennifer-shehane added this to the 0.17.x milestone Sep 30, 2016
@jennifer-shehane jennifer-shehane removed this from the 0.17.x milestone Feb 3, 2017
@verheyenkoen

This comment was marked as outdated.

Copy link
Contributor

@verheyenkoen verheyenkoen commented Oct 25, 2017

Could this be a first-timers-only issue?

@cypress-bot

This comment has been minimized.

Copy link

@cypress-bot cypress-bot bot commented Nov 12, 2019

The code for this is done in cypress-io/cypress#5619, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

1 similar comment
@cypress-bot

This comment has been minimized.

Copy link

@cypress-bot cypress-bot bot commented Nov 12, 2019

The code for this is done in cypress-io/cypress#5619, but has yet to be released.
We'll update this issue and reference the changelog when it's released.

@cypress-bot

This comment has been minimized.

Copy link

@cypress-bot cypress-bot bot commented Nov 27, 2019

Released in 3.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
You can’t perform that action at this time.