Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug 1.1 - Update max-widths for empty state and non failed run copy #25669

Closed
warrensplayer opened this issue Feb 1, 2023 · 2 comments · Fixed by #25725
Closed

Debug 1.1 - Update max-widths for empty state and non failed run copy #25669

warrensplayer opened this issue Feb 1, 2023 · 2 comments · Fixed by #25725
Assignees

Comments

@warrensplayer
Copy link
Contributor

** Current behavior**
The copy used for Debug page empty states and for the non-failed status use cases have widths that do not match the designs.

Example empty state
image.png

DebugOverLimit
Screenshot 2023-02-01 at 12.38.45 PM.png

** Desired behavior**
Update the widths for these different components to match the designs.

The empty state components should have a max width of 640px.

  • DebugNotLoggedIn
  • DebugNoProject
  • DebugNoRuns
  • DebugError

With 640px max width
image.png

Figma: https://www.figma.com/file/PAOozuCxtfetqP8fUVvg0y/branch/QkCp2F69X0qyLo7qnYQ67e/Cypress-App?node-id=21167%3A199979&t=kRQDympkDV8byvGw-1

The non-failed status components should have a max-width of 440px.

  • DebugOverLimit

With 440px max width
Screenshot 2023-02-01 at 12.40.21 PM.png

Figma: https://www.figma.com/file/PAOozuCxtfetqP8fUVvg0y/branch/QkCp2F69X0qyLo7qnYQ67e/Cypress-App?node-id=21180%3A190683&t=kRQDympkDV8byvGw-1

@warrensplayer
Copy link
Contributor Author

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 15, 2023

Released in 12.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants