Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug 1.1 - Include avatar in Debug page header if available #25796

Closed
warrensplayer opened this issue Feb 13, 2023 · 5 comments · Fixed by #25823
Closed

Debug 1.1 - Include avatar in Debug page header if available #25796

warrensplayer opened this issue Feb 13, 2023 · 5 comments · Fixed by #25823
Assignees

Comments

@warrensplayer
Copy link
Contributor

warrensplayer commented Feb 13, 2023

Current Behavior

The avatar for the commit author shown in the Debug page header is hardcoded to a fixed user icon.

header

Desired behavior

Update the code to use the commitInfo.authorAvatar url under the run if present. If not, fallback to the icon.

@warrensplayer
Copy link
Contributor Author

@astone123
Copy link
Contributor

Do we know if authorAvatar is an email address or a URL? Currently the way that we do this in other areas of the app is by using the UserAvatar component which tries to get a Gravatar for the email address. If it doesn't find one then it falls back to the default icon.

@marktnoonan
Copy link
Contributor

Based on services repo, it's a gravatar url already so we just need to render the provided image.

@astone123
Copy link
Contributor

@marktnoonan okay, we can probably just update the UserAvatar component to accept a URL rather than an email

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Feb 25, 2023

Released in 12.7.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.7.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Feb 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants