Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Location of recorded video is not printed if videoCompression: false #25945

Closed
jennifer-shehane opened this issue Feb 24, 2023 · 1 comment · Fixed by #26813
Closed

Location of recorded video is not printed if videoCompression: false #25945

jennifer-shehane opened this issue Feb 24, 2023 · 1 comment · Fixed by #26813

Comments

@jennifer-shehane
Copy link
Member

Current behavior

If you're recording with videoCompression set to some number (other than 0), a section for Video output is displays to the terminal like shown below. This information contains progress around compression time and time it takes to process the video in general, but it also includes a link to the video which is valuable to see where the video is recorded.

Screen Shot 2023-02-24 at 2 35 30 PM

If you turn off videoCompression, setting it to false - this entire section is not printed. So you can't see the location of the recorded video. There was a recorded video below, but no one would know.

Screen Shot 2023-02-24 at 2 37 05 PM

Desired behavior

This line of code, as well as the Video section title itself should still print when videoCompression is set to false. https://github.com/cypress-io/cypress/blob/develop/packages/server/lib/util/print-run.ts#L540

This isn't happening because this entire section of printing in only ocurring if there is progression in processing the video. Really the link to the video should be separated out into a section that's always printed when video is present. https://github.com/cypress-io/cypress/blob/develop/packages/server/lib/video_capture.ts#L371:L371

Test code to reproduce

Run the code below in any project.

cypress.config.js

const { defineConfig } = require('cypress')

module.exports = defineConfig({
  videoCompression: false
})

Cypress Version

12.5.1

Node version

16.16.1

Operating System

Mac

Debug Logs

No response

Other

No response

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jun 20, 2023

Released in 12.15.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.15.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant