Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug - Add Chrome Beta Icon #25968

Closed
warrensplayer opened this issue Feb 27, 2023 · 2 comments · Fixed by #26027
Closed

Debug - Add Chrome Beta Icon #25968

warrensplayer opened this issue Feb 27, 2023 · 2 comments · Fixed by #26027
Assignees
@jordanpowell88
Labels
CT Issue related to component testing

Comments

@warrensplayer
Copy link
Contributor

Current behavior

In LayeredBrowserIcons that is used on the Debug page, the icon for the regular "Chrome" browser is being used for the "Chrome Beta" browser. This can make the UI look like it is duplicating browsers when it should be showing a unique list.

Desired behavior

Add the correct SVG icon for the "Chrome Beta" browser to the design system and use it in LayeredBrowserIcons.

For reference, the cypress-services repo has a PNG icon that it uses located here: https://github.com/cypress-io/cypress-services/blob/46073cb5c387af3b203404280a1664a85e233b93/frontend/packages/dashboard/src/lib/img/chrome-beta_32x32.png
@warrensplayer warrensplayer added the CT Issue related to component testing label Feb 27, 2023
@warrensplayer
Copy link
Contributor Author

Hey team! Please add your planning poker estimate with Zenhub @astone123 @lmiller1990 @marktnoonan @mike-plummer @ZachJW34

@jordanpowell88 jordanpowell88 self-assigned this Mar 6, 2023
This was referenced Mar 6, 2023
Merged
Merged
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Mar 14, 2023

Released in 12.8.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.8.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jordanpowell88 jordanpowell88

Labels
CT Issue related to component testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(app): add google beta icon cypress-io/cypress
2 participants
@warrensplayer @jordanpowell88