Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/correct Debug Page UI when viewing run with no failures but organization is over the record limit #26528

Closed
warrensplayer opened this issue Apr 18, 2023 · 1 comment · Fixed by #26533
Assignees

Comments

@warrensplayer
Copy link
Contributor

warrensplayer commented Apr 18, 2023

Current behavior

If a Cloud organization has gone over the record limit for the subscription they have, then the Debug page will not return any failed tests in the testsForReview field. The UI will show a message indicating that the account is over the limit and provide a CTA for how to upgrade the account.

When viewing a run on the Debug page with no failures, then a success message is shown to indicate that all tests have passed. If both of these states occur at the same time, then the messages are stacked. This UI does not look good and is confusing to users. (see screenshot)

image.png

Desired behavior

Only show the DebugOverLimit component and hide the DebugPassed component in this scenario. This code is in the DebugPageDetails component.

<DebugPassed v-if="status === 'PASSED'" />
<DebugOverLimit
v-if="isHidden"
:over-limit-reasons="reasonsRunIsHidden"
:over-limit-action-type="overLimitActionType"
:over-limit-action-url="overLimitActionUrl"
:run-age-days="runAgeDays"
/>

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Apr 26, 2023

Released in 12.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.11.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants