Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change 'Processing' to 'Compressing' in terminal video output #26657

Closed
jennifer-shehane opened this issue May 3, 2023 · 4 comments · Fixed by #26800
Closed

Change 'Processing' to 'Compressing' in terminal video output #26657

jennifer-shehane opened this issue May 3, 2023 · 4 comments · Fixed by #26800
Labels
good first issue Good for newcomers

Comments

@jennifer-shehane
Copy link
Member

jennifer-shehane commented May 3, 2023

What would you like?

In the context of users being confused around where time is going into 'Processing' videos (is it compression, saving to disk, uploading to cloud?), we want to change the word 'Processing' to 'Compressing' in the terminal output when video's are compressed

Also ensure any other terminal or debug output is accurate in communicating 'compression' or 'upload' as appropriate, as opposed to the terminology of 'processing'. For example, there is a debug log about 'video not found - skipping processing', could this be more explicit to what is being skipped?

Why is this needed?

This is a low effort fix that will allow users to know that changing the videoCompression option directly affects this action Cypress takes that's printed to the terminal.

@mahdikhashan
Copy link
Contributor

@jennifer-shehane could you assign it to me?

@jennifer-shehane
Copy link
Member Author

@mahdikhashan If you'd like to open a PR, our team will review the work. So feel free to implement.

@jennifer-shehane
Copy link
Member Author

Adding additional requirements in the original comment: "Also ensure any other terminal or debug output is accurate in communicating 'compression' or 'upload' as appropriate, as opposed to the terminology of 'processing'. For example, there is a debug log about 'video not found - skipping processing', could this be more explicit to what is being skipped?"

@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 23, 2023

Released in 12.13.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.13.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants