Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sidebar icon for Runs page to show latest run status #27206

Closed
warrensplayer opened this issue Jul 5, 2023 · 2 comments · Fixed by #27672
Closed

Update sidebar icon for Runs page to show latest run status #27206

warrensplayer opened this issue Jul 5, 2023 · 2 comments · Fixed by #27672
Assignees

Comments

@warrensplayer
Copy link
Contributor

warrensplayer commented Jul 5, 2023

Summary

To better show the status of the latest Run, the App sidebar will use icons to show the status of the latest run in the list shown on the Runs page.

Data

Pull the status for the first run in the latest array returned by the useRelevantRuns composable in SidebarNavigationContainer

If there are no runs returned (for any reason), then just show the existing icon.

Icons

Status Icon Note
Running image Animated
Failing image Animated
Passed image
Failed image
Cancelled image
Errored, Timed Out, Over Limit, No Tests image

Failing

Note FAILING is not an actual CloudRunStatus. It will need to be derived by passing through the totalFailed count on the RelevantRunInfo GQL type via the useRelevantRuns composable. The logic should be to show the "Failing" icon if the actual status is RUNNING and the totalFailed count is greater than 0.

References

Clickup: https://app.clickup.com/18033298/docs/h6amj-45987/h6amj-53707?block=block-98aef273-8b18-476a-92c0-5b1de90b06fb
Figma: https://www.figma.com/file/90FM8BU3k1HgsjOiDovpnn/In-App-Run-Notifications?type=design&node-id=443-32494&mode=design&t=NYPLOxWN8VrhxChv-0

@warrensplayer
Copy link
Contributor Author

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 31, 2023

Released in 13.1.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.1.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants