Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requests that are cached in service workers can be improperly correlated in the proxy #28056

Closed
ryanthemanuel opened this issue Oct 13, 2023 · 1 comment · Fixed by #28060
Closed
Assignees

Comments

@ryanthemanuel
Copy link
Collaborator

ryanthemanuel commented Oct 13, 2023

Current behavior

It appears what's getting received here is:

Browser
Test 1

  • Request for A - request normally made from document
  • Request for B - request made from the service worker in order to cache (the way service workers work, you don't start using the cache until the next load of the site)
    Test 2
  • Request for C

Proxy
Test 1

  • A
  • B
    Test 2 (Nothing. Since now everything is cached)

CDP
Test 1 (B doesn't arrive. Seems like service worker requests don't go through CDP)

  • A
    Test 2
  • C

So B ends up timing out during the correlation phase.

Desired behavior

We should either find a way to ignore requests that are being made from service workers in terms of correlation. Or we need to get the request information somewhere else.

Cypress Version

13.3.1

Node version

18.15.0

Operating System

any

Debug Logs

No response

Other

No response

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 18, 2023

Released in 13.3.2.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.3.2, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant